Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve all pkg dependencies #722

Merged
merged 2 commits into from
Jun 18, 2019
Merged

resolve all pkg dependencies #722

merged 2 commits into from
Jun 18, 2019

Conversation

marwan-at-work
Copy link
Contributor

Fixes #721

@mathewbyrne
Copy link
Contributor

Thanks for the fix. Would you mind please adding a test case that demonstrates the issue?

@marwan-at-work
Copy link
Contributor Author

marwan-at-work commented Jun 15, 2019 •
edited
Loading

@mathewbyrne no problem. I'm not too familiar with the codebase. I'd be happy to add a test case if I knew where/how I can define Go code with type declarations and somehow target the NewBinder function in my unit tests. Thanks :)

@vektah vektah added the v0.9.1 fixed in v0.9.1 label Jun 18, 2019
@vektah vektah merged commit 090f0bd into 99designs:master Jun 18, 2019
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
@vektah
Merge pull request 99designs#722 from marwan-at-work/deps
41b7381 
resolve all pkg dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v0.9.1 fixed in v0.9.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic when model is a type definition of another package
3 participants
@marwan-at-work @mathewbyrne @vektah